Problems in function ExpandForWildCards

[Heiko]

Hi Kevin,

I'm Heiko formerly known as Heiko Schrder

Some users of my software get the following error:
(output of EurekaLog)

----------------------------------------------------------------------------------
|Address |Module |Unit |Class |Procedure/Method |Line|
----------------------------------------------------------------------------------
|004C5331|mobackup.exe|VCLZip.pas |TVCLZip |ExpandForWildCards |906 |
|004C5250|mobackup.exe|VCLZip.pas |TVCLZip |ExpandForWildCards |894 |
|004C6D50|mobackup.exe|VCLZip.pas |TVCLZip |ProcessFiles |1467|
|004C6BE0|mobackup.exe|VCLZip.pas |TVCLZip |ProcessFiles |1439|
|004C4EA4|mobackup.exe|VCLZip.pas |TVCLZip |Zip |791 |
|004C4E7C|mobackup.exe|VCLZip.pas |TVCLZip |Zip |788 |
----------------------------------------------------------------------------------

On the line 906 on VCLZip.pas you check the last letter of the filelist.
What can be the problem?

Best regards
Heiko

[Kevin]

What is the error?

And what is the wildcard that is causing the problem?

[Heiko]

I dont use wildcards to add files. I use the method FilesList.Add and allot the exact filename. There are not empty directories.

Here is my code in Delphi 5:

----
CheckListBox : TCheckListBox;
Zip : TVCLZip;
-----

for i := 0 to (CheckListBox.Items.Count-1) do
if CheckListBox.Checked then
Zip.FilesList.Add(String(CheckListBox.Items.Objects));

If Zip.FilesList.Count > 0 then
begin
Application.ProcessMessages;

if Zip.Zip < 1 then
MsgWindow(txt_ZipError, const_ProgName, mtError, [mbOk]);
end;

And here is the error. The error not ever occur. But if the error occurs always the adress is changed.

Exception...
Address: 0048D5ED
Type : EAccessViolation
Message: Zugriffsverletzung bei Adresse 0048D5ED. Lesen von Adresse 0196B3C7.

Computer...
Total Memory: 2047 Mb
Free Memory : 1532 Mb
Total Disk : 231,84 Gb
Free Disk : 206,5 Gb

Operating System...
Type : Microsoft Windows XP
Build # : 2600
Language: Deutsch (Deutschland)

On the list at my first message you can see on which lines the VCLZip functions will be entered. You have to read it from bottom to top.

[Kevin]

Sorry for the delay. I finally got a chance to look at the code in question here...

Line 906 simply checks the last character of the FilesList entry (as you noticed too) to see if it is a directory. I can't think of a reason for an exception unless there is no entry at that index, or a null was entered at that position in the FilesList array. Is there any chance that your program is entering a null, or some corrupted string?

Also, out of curiosity, do you know if this always happens on the first, or last entry in the FilesList array, or some pattern such as this?

Kevin

[Heiko]

Also sorry for the delay ;-)

Now I can force the problem. If I add an empty string to the filelist the error occurs. So the problem has to be solved in my routines.

To improve VCLZip it should check and react to the empty filename.

Have a nice day.