Memory leak problem with deleteEntries

[Macaos]

Based on some conditionals I delete files in a zip archive. If these conditionals happen to cause all the files in the archive to be deleted i get memory leaks:

37 - 44 bytes: UnicodeString x 1
45 - 52 bytes: TSortedZip x 1

The code below wil produce these memory leaks:

var
 VCLZip: TVCLZip;
 MS: TMemoryStream;
 i: Integer;
begin
 MS:=TMemoryStream.Create;
 MS.LoadFromFile('test.zip');
 VCLZip:=TVCLZip.Create(nil);
 VCLZip.ArchiveStream:=MS;
 VCLZip.ReadZip;
 for i := 0 to VCLZip.Count - 1 do
   VCLZip.Selected[i]:=True;
 VCLZip.DeleteEntries;
 MS:=TMemoryStream(VCLZip.ArchiveStream);
 MS.Free;
 VCLZip.ArchiveStream:=nil;
 VCLZip.Free;


Memory leaks will also occur when calling deleteEntries with no file loaded into archivestream:

45 - 52 bytes: TSortedZip x 1

var
 VCLZip: TVCLZip;
 MS: TMemoryStream;
begin
 MS:=TMemoryStream.Create;
 VCLZip:=TVCLZip.Create(nil);
 VCLZip.ArchiveStream:=MS;
 VCLZip.DeleteEntries;
 MS:=TMemoryStream(VCLZip.ArchiveStream);
 MS.Free;
 VCLZip.ArchiveStream:=nil;
 VCLZip.Free;


Is this a bug or is there a way to avoid these memory leaks?

Ørjan Nilsen

[Kevin]

Hi Ørjan,

I will take a look and see what I can find.

1) What version of VCLZip are you using?

2) And what version of Delphi are you using?

3) And, just to be sure I understood, in the first case, the only time there is a memory leak is if all of the files are deleted from the archive? So if there are any entries left, there is no memory leak?

Thanks!

Kevin

[Macaos]

1. VCLZip 4.50
2. Delphi 2009
3. You understood correct!

Ørjan

[Kevin]

OK, thanks. That helps narrow it down. I will take a look and get back. It may be tomorrow before I have something to report.

Kevin

[Kevin]

I'm still looking at this. I did not get a chance to look yesterday.

Kevin

[Kevin]

I have a question... Do you set the SortMode property to anything besides ByName in your code?

[Macaos]

No I dont change the SortMode property.

[Macaos]

Are you still looking at this Kevin?

Ørjan

[Kevin]

Yes, sorry about getting distracted, but we wanted to get the fix for ansi filenames out as quickly as possible. I will continue looking at this one again today. I have a pretty good idea where the problem is, I just have to verify that I am right.

Kevin

[Kevin]

Ørjan,

I sent you a fix for this by email last night, to try out, and verify that it works for you too. Did you get that?

Kevin

[Macaos]

Thanks. That did the trick. The memory leak is gone now.